This commit is contained in:
2025-11-14 10:34:43 -07:00
parent 3be92aea3c
commit b8fd938120
4 changed files with 111 additions and 4 deletions

View File

@@ -296,3 +296,57 @@ fn copy_paste_vars_translate() {
let a = app.grid.get_cell("A0").as_ref().expect("Should've been set by paste"); let a = app.grid.get_cell("A0").as_ref().expect("Should've been set by paste");
assert_eq!(a.to_string(), "=A1"); assert_eq!(a.to_string(), "=A1");
} }
#[test]
fn copy_paste_double_locked_var() {
let mut app = App::new();
app.grid.set_cell("A0", 0.);
app.grid.set_cell("A1", "=$A$0".to_string());
// Copy A0
app.grid.mv_cursor_to(0, 1);
app.mode = super::mode::Mode::Chord(Chord::new('y'));
Mode::process_key(&mut app, 'y');
app.grid.mv_cursor_to(1, 0);
Mode::process_key(&mut app, 'p');
let c = app.grid.get_cell("B0").as_ref().expect("Just set it");
assert_eq!(c.to_string(), "=$A$0");
}
#[test]
fn copy_paste_x_locked_var() {
let mut app = App::new();
app.grid.set_cell("A0", 0.);
app.grid.set_cell("A1", "=$A0".to_string());
// Copy A0
app.grid.mv_cursor_to(0, 1);
app.mode = super::mode::Mode::Chord(Chord::new('y'));
Mode::process_key(&mut app, 'y');
app.grid.mv_cursor_to(1, 2);
Mode::process_key(&mut app, 'p');
let c = app.grid.get_cell("B2").as_ref().expect("Just set it");
assert_eq!(c.to_string(), "=$A1");
}
#[test]
fn copy_paste_y_locked_var() {
let mut app = App::new();
app.grid.set_cell("A0", 0.);
app.grid.set_cell("A1", "=A$0".to_string());
// Copy A0
app.grid.mv_cursor_to(0, 1);
app.mode = super::mode::Mode::Chord(Chord::new('y'));
Mode::process_key(&mut app, 'y');
app.grid.mv_cursor_to(1, 2);
Mode::process_key(&mut app, 'p');
let c = app.grid.get_cell("B2").as_ref().expect("Just set it");
assert_eq!(c.to_string(), "=B$0");
}

View File

@@ -379,6 +379,8 @@ impl Grid {
/// Parse values in the format of A0, C10 ZZ99, etc, and /// Parse values in the format of A0, C10 ZZ99, etc, and
/// turn them into an X,Y index. /// turn them into an X,Y index.
pub fn parse_to_idx(i: &str) -> Option<(usize, usize)> { pub fn parse_to_idx(i: &str) -> Option<(usize, usize)> {
let i = i.replace('$', "");
let chars = i.chars().take_while(|c| c.is_alphabetic()).collect::<Vec<char>>(); let chars = i.chars().take_while(|c| c.is_alphabetic()).collect::<Vec<char>>();
let nums = i.chars().skip(chars.len()).take_while(|c| c.is_numeric()).collect::<String>(); let nums = i.chars().skip(chars.len()).take_while(|c| c.is_numeric()).collect::<String>();
@@ -474,6 +476,9 @@ fn cell_strings() {
#[test] #[test]
fn alphanumeric_indexing() { fn alphanumeric_indexing() {
assert_eq!(Grid::parse_to_idx("A0"), Some((0, 0))); assert_eq!(Grid::parse_to_idx("A0"), Some((0, 0)));
assert_eq!(Grid::parse_to_idx("$A0"), Some((0, 0)));
assert_eq!(Grid::parse_to_idx("A$0"), Some((0, 0)));
assert_eq!(Grid::parse_to_idx("$A$0"), Some((0, 0)));
assert_eq!(Grid::parse_to_idx("AA0"), Some((26, 0))); assert_eq!(Grid::parse_to_idx("AA0"), Some((26, 0)));
assert_eq!(Grid::parse_to_idx("A1"), Some((0, 1))); assert_eq!(Grid::parse_to_idx("A1"), Some((0, 1)));
assert_eq!(Grid::parse_to_idx("A10"), Some((0, 10))); assert_eq!(Grid::parse_to_idx("A10"), Some((0, 10)));

View File

@@ -66,6 +66,37 @@ impl CellType {
let mut rolling = eq.clone(); let mut rolling = eq.clone();
// translate standard vars A0 -> A1 // translate standard vars A0 -> A1
for old_var in ctx.dump_vars() { for old_var in ctx.dump_vars() {
let mut lock_x = false;
let mut lock_y = false;
if old_var.contains('$') {
let locations = old_var.char_indices().filter(|(_, c)| *c == '$').map(|(i, _)| i).collect::<Vec<usize>>();
match locations.len() {
1 => {
if locations[0] == 0 {
// locking the X axis (A,B,C...)
lock_x = true;
} else if locations[0] < old_var.len() {
// inside the string somewhere, gonna assume this means to lock Y (1,2,3...)
lock_y = true;
} else {
// where tf is this dollar sign?
// (It's somewhere malformed, like A0$ or something)
}
}
2 => {
// YOLO, lock both X & Y
continue; // just pretend you never even saw this var
}
_ => {
// Could probably optimize the code or something so you only go over the string
// once, instead of contains() then getting the indexes of where it is.
// You could then put your no-$ code here.
}
}
}
if let Some((src_x, src_y)) = Grid::parse_to_idx(&old_var) { if let Some((src_x, src_y)) = Grid::parse_to_idx(&old_var) {
let (x1, y1) = from; let (x1, y1) = from;
let x1 = x1 as i32; let x1 = x1 as i32;
@@ -74,12 +105,29 @@ impl CellType {
let x2 = x2 as i32; let x2 = x2 as i32;
let y2 = y2 as i32; let y2 = y2 as i32;
let dest_x = (src_x as i32 + (x2 - x1)) as usize; let dest_x = if lock_x {
let dest_y = (src_y as i32 + (y2 - y1)) as usize; src_x as usize
} else {
(src_x as i32 + (x2 - x1)) as usize
};
let dest_y = if lock_y {
src_y as usize
} else {
(src_y as i32 + (y2 - y1)) as usize
};
let alpha = Grid::num_to_char(dest_x); let alpha = Grid::num_to_char(dest_x);
let alpha = alpha.trim(); let alpha = alpha.trim();
let new_var = format!("{alpha}{dest_y}");
let new_var = if lock_x {
format!("${alpha}{dest_y}")
} else if lock_y {
format!("{alpha}${dest_y}")
} else {
format!("{alpha}{dest_y}")
};
// swap out vars // swap out vars
rolling = replace_fn(&rolling, &old_var, &new_var); rolling = replace_fn(&rolling, &old_var, &new_var);

View File

@@ -295,7 +295,7 @@ impl Context for ExtractionContext {
registry.push(identifier.to_owned()) registry.push(identifier.to_owned())
} else { panic!("The RwLock should always be write-able") } } else { panic!("The RwLock should always be write-able") }
// Ok(Value::Int(1)) // Ok(Value::Int(1))
todo!(); unimplemented!("Extracting function identifier not implemented yet")
} }
fn are_builtin_functions_disabled(&self) -> bool { fn are_builtin_functions_disabled(&self) -> bool {